Changeset 47381 for trunk/tests/phpunit/tests/post/types.php

Timestamp:

02/26/2020 01:16:10 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Remove redundant Tests_Post_Types::register_post_type() helper method, use register_post_type() directly.

Props gh640, varunshanbhag.
Fixes #49365.

File:

• trunk/tests/phpunit/tests/post/types.php (modified) (7 diffs)

trunk/tests/phpunit/tests/post/types.php

@@ -76 +76 @@
          * 'exclude_from_search' Default is null (opposite 'public')
          */
-        $args = $this->register_post_type( array( 'public' => $public = false ) );
+        $args = register_post_type( $this->post_type, array( 'public' => $public = false ) );
 
         $this->assertNotEquals( $public, $args->exclude_from_search );
@@ -90 +90 @@
          * 'publicly_queryable' Default is null ('public')
          */
-        $args = $this->register_post_type( array( 'public' => $public = false ) );
+        $args = register_post_type( $this->post_type, array( 'public' => $public = false ) );
 
         $this->assertSame( $public, $args->publicly_queryable );
@@ -104 +104 @@
          * 'show_ui' Default is null ('public')
          */
-        $args = $this->register_post_type( array( 'public' => $public = false ) );
+        $args = register_post_type( $this->post_type, array( 'public' => $public = false ) );
 
         $this->assertSame( $public, $args->show_ui );
@@ -119 +119 @@
          * 'show_in_menu Default is null ('show_ui' > 'public')
          */
-        $args = $this->register_post_type( array( 'public' => $public = false ) );
+        $args = register_post_type( $this->post_type, array( 'public' => $public = false ) );
 
         // Should fall back to 'show_ui'.
@@ -137 +137 @@
          * 'show_in_nav_menus' Default is null ('public')
          */
-        $args = $this->register_post_type( array( 'public' => $public = false ) );
+        $args = register_post_type( $this->post_type, array( 'public' => $public = false ) );
 
         $this->assertSame( $public, $args->show_in_nav_menus );
@@ -152 +152 @@
          * 'show_in_admin_bar' Default is null ('show_in_menu' > 'show_ui' > 'public')
          */
-        $args = $this->register_post_type( array( 'public' => $public = false ) );
+        $args = register_post_type( $this->post_type, array( 'public' => $public = false ) );
 
         // Should fall back to 'show_in_menu'.
@@ -573 +573 @@
         $this->assertEqualSets( array(), get_post_types_by_support( 'somefeature' ) );
     }
-
-    /**
-     * Serves as a helper to register a post type for tests.
-     *
-     * Uses `$this->post_type` initialized in setUp().
-     *
-     * @since 4.5.0
-     *
-     * @param array $args register_post_type() arguments.
-     * @return WP_Post_Type Post type object for `$this->post_type`.
-     */
-    public function register_post_type( $args = array() ) {
-        register_post_type( $this->post_type, $args );
-        return get_post_type_object( $this->post_type );
-    }
 }