Changeset 47395

Timestamp:

02/29/2020 11:43:57 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Privacy: Make the progress indicator for export and erasure visible even if not hovered over.

Follow-up to [47246].

Props pbiron, garrett-eclipse.
Fixes #44264.

Location:

trunk/src

Files:

• js/_enqueues/admin/privacy-tools.js (modified) (13 diffs)
• wp-admin/css/forms.css (modified) (1 diff)

trunk/src/js/_enqueues/admin/privacy-tools.js

@@ -61 +61 @@
                         $requestRow    = $this.parents( 'tr' ),
                         $progress      = $requestRow.find( '.export-progress' ),
+                        $rowActions    = $this.parents( '.row-actions' ),
                         requestID      = $action.data( 'request-id' ),
                         nonce          = $action.data( 'nonce' ),
@@ -69 +70 @@
                 event.stopPropagation();
 
+                $rowActions.addClass( 'processing' );
+
                 $action.blur();
                 clearResultsAfterRow( $requestRow );
@@ -79 +82 @@
 
                         appendResultsAfterRow( $requestRow, 'notice-success', summaryMessage, [] );
-                        $this.hide();
 
                         if ( 'undefined' !== typeof zipUrl ) {
@@ -86 +88 @@
                                 onExportFailure( strings.noExportFile );
                         }
+
+                        setTimeout( function(){ $rowActions.removeClass( 'processing' ); }, 500 );
                 }
 
@@ -93 +97 @@
                                 appendResultsAfterRow( $requestRow, 'notice-error', strings.exportError, [ errorMessage ] );
                         }
+
+                        setTimeout( function(){ $rowActions.removeClass( 'processing' ); }, 500 );
                 }
 
@@ -119 +125 @@
 
                                 if ( ! response.success ) {
-
                                         // e.g. invalid request ID.
-                                        onExportFailure( response.data );
+                                        setTimeout( function(){ onExportFailure( response.data ); }, 500 );
                                         return;
                                 }
@@ -128 +133 @@
                                         setTimeout( doNextExport( exporterIndex, pageIndex + 1 ) );
                                 } else {
+                                        setExportProgress( exporterIndex );
                                         if ( exporterIndex < exportersCount ) {
-                                                setExportProgress( exporterIndex );
                                                 setTimeout( doNextExport( exporterIndex + 1, 1 ) );
                                         } else {
-                                                onExportDoneSuccess( responseData.url );
+                                                setTimeout( function(){ onExportDoneSuccess( responseData.url ); }, 500 );
                                         }
                                 }
                         }).fail( function( jqxhr, textStatus, error ) {
-
                                 // e.g. Nonce failure.
-                                onExportFailure( error );
+                                setTimeout( function(){ onExportFailure( error ); }, 500 );
                         });
                 }
@@ -152 +156 @@
                         $requestRow   = $this.parents( 'tr' ),
                         $progress     = $requestRow.find( '.erasure-progress' ),
+                        $rowActions   = $this.parents( '.row-actions' ),
                         requestID     = $action.data( 'request-id' ),
                         nonce         = $action.data( 'nonce' ),
@@ -159 +164 @@
                         messages      = [];
 
+                event.preventDefault();
                 event.stopPropagation();
+
+                $rowActions.addClass( 'processing' );
 
                 $action.blur();
@@ -187 +195 @@
                         }
                         appendResultsAfterRow( $requestRow, classes, summaryMessage, messages );
-                        $this.hide();
+
+                        setTimeout( function(){ $rowActions.removeClass( 'processing' ); }, 500 );
                 }
 
@@ -193 +202 @@
                         setActionState( $action, 'remove-personal-data-failed' );
                         appendResultsAfterRow( $requestRow, 'notice-error', strings.removalError, [] );
+
+                        setTimeout( function(){ $rowActions.removeClass( 'processing' ); }, 500 );
                 }
 
@@ -216 +227 @@
 
                                 if ( ! response.success ) {
-                                        onErasureFailure();
+                                        setTimeout( function(){ onErasureFailure(); }, 500 );
                                         return;
                                 }
@@ -231 +242 @@
                                         setTimeout( doNextErasure( eraserIndex, pageIndex + 1 ) );
                                 } else {
+                                        setErasureProgress( eraserIndex );
                                         if ( eraserIndex < erasersCount ) {
-                                                setErasureProgress( eraserIndex );
                                                 setTimeout( doNextErasure( eraserIndex + 1, 1 ) );
                                         } else {
-                                                onErasureDoneSuccess();
+                                                setTimeout( function(){ onErasureDoneSuccess(); }, 500 );
                                         }
                                 }
                         }).fail( function() {
-                                onErasureFailure();
+                                setTimeout( function(){ onErasureFailure(); }, 500 );
                         });
                 }

trunk/src/wp-admin/css/forms.css

@@ -1207 +1207 @@
 }
 
+.privacy_requests .row-actions.processing {
+        position: static;
+}
+
 .privacy_requests tbody .has-request-results th {
         box-shadow: none;