WordPress.org

Make WordPress Core

Changeset 47410


Ignore:
Timestamp:
03/03/2020 12:35:41 AM (21 months ago)
Author:
johnbillion
Message:

Editor: Revert a fix for incorrect usage of ID attributes on custom fields.

This reverts [47222] due to compatibility issues with plugins which are using the #poststuff selector.

See #46964

Location:
trunk/src
Files:
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/js/_enqueues/admin/postbox.js

    r47222 r47410  
    422422                case 0:
    423423                case 180:
    424                     if ( $( '.poststuff' ).length ) {
     424                    if ( $( '#poststuff' ).length ) {
    425425                        this._pb_edit(1);
    426426                    } else {
  • trunk/src/wp-admin/css/dashboard.css

    r47255 r47410  
    77}
    88
    9 #wpbody-content #dashboard-widgets.columns-2 .postbox-container-2,
     9#wpbody-content #dashboard-widgets.columns-2 #postbox-container-2,
    1010#wpbody-content #dashboard-widgets.columns-2 #postbox-container-3,
    1111#wpbody-content #dashboard-widgets.columns-2 #postbox-container-4 {
     
    4343}
    4444
    45 .ie8 #wpbody-content #dashboard-widgets .postbox-container-2,
     45.ie8 #wpbody-content #dashboard-widgets #postbox-container-2,
    4646.ie8 #wpbody-content #dashboard-widgets #postbox-container-3,
    4747.ie8 #wpbody-content #dashboard-widgets #postbox-container-4 {
     
    11131113    }
    11141114
    1115     #wpbody-content #dashboard-widgets .postbox-container-2,
     1115    #wpbody-content #dashboard-widgets #postbox-container-2,
    11161116    #wpbody-content #dashboard-widgets #postbox-container-3,
    11171117    #wpbody-content #dashboard-widgets #postbox-container-4 {
  • trunk/src/wp-admin/css/edit.css

    r47252 r47410  
    1 .poststuff {
     1#poststuff {
    22    padding-top: 10px;
    33    min-width: 763px;
    44}
    55
    6 .poststuff #post-body {
     6#poststuff #post-body {
    77    padding: 0;
    88}
    99
    10 .poststuff .postbox-container {
     10#poststuff .postbox-container {
    1111    width: 100%;
    1212}
    1313
    14 .poststuff #post-body.columns-2 {
     14#poststuff #post-body.columns-2 {
    1515    margin-right: 300px;
    1616}
     
    5252}
    5353
    54 .poststuff #titlewrap {
     54#poststuff #titlewrap {
    5555    border: 0;
    5656    padding: 0;
     
    415415}
    416416
    417 .poststuff #post-body.columns-2 #side-sortables {
     417#poststuff #post-body.columns-2 #side-sortables {
    418418    width: 280px;
    419419}
     
    606606}
    607607
    608 .poststuff h3.hndle, /* Back-compat for pre-4.4 */
    609 .poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
    610 .poststuff h2 {
     608#poststuff h3.hndle, /* Back-compat for pre-4.4 */
     609#poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
     610#poststuff h2 {
    611611    font-size: 14px;
    612612    padding: 8px 12px;
     
    615615}
    616616
    617 .poststuff .stuffbox h2 {
     617#poststuff .stuffbox h2 {
    618618    padding: 8px 10px;
    619619}
    620620
    621 .poststuff .stuffbox > h2 {
     621#poststuff .stuffbox > h2 {
    622622    border-bottom: 1px solid #eee;
    623623}
    624624
    625 .poststuff .inside {
     625#poststuff .inside {
    626626    margin: 6px 0 0 0;
    627627}
    628628
    629 .poststuff .stuffbox .inside {
     629#poststuff .stuffbox .inside {
    630630    margin: 0;
    631631}
    632632
    633 .poststuff .inside #parent_id,
    634 .poststuff .inside #page_template {
     633#poststuff .inside #parent_id,
     634#poststuff .inside #page_template {
    635635    max-width: 100%;
    636636}
    637637
    638 .ie8 .poststuff .inside #parent_id,
    639 .ie8 .poststuff .inside #page_template {
     638.ie8 #poststuff .inside #parent_id,
     639.ie8 #poststuff .inside #page_template {
    640640    width: 250px;
    641641}
     
    657657
    658658#linksubmitdiv .inside, /* Old Link Manager back-compat. */
    659 .poststuff #submitdiv .inside {
     659#poststuff #submitdiv .inside {
    660660    margin: 0;
    661661    padding: 0;
     
    11061106------------------------------------------------------------------------------*/
    11071107
    1108 .poststuff .tagsdiv .ajaxtag {
     1108#poststuff .tagsdiv .ajaxtag {
    11091109    margin-top: 1em;
    11101110}
    11111111
    1112 .poststuff .tagsdiv .howto {
     1112#poststuff .tagsdiv .howto {
    11131113    margin: 1em 0 6px 0;
    11141114}
     
    11551155}
    11561156
    1157 .poststuff .inside .the-tagcloud {
     1157#poststuff .inside .the-tagcloud {
    11581158    margin: 5px 0 10px;
    11591159    padding: 8px;
     
    14271427/* one column on the post write/edit screen */
    14281428@media only screen and (max-width: 850px) {
    1429     .poststuff {
     1429    #poststuff {
    14301430        min-width: 0;
    14311431    }
    14321432
    1433     #wpbody-content .poststuff #post-body {
     1433    #wpbody-content #poststuff #post-body {
    14341434        margin: 0;
    14351435    }
     
    14401440    }
    14411441
    1442     .poststuff #postbox-container-1 .empty-container,
    1443     .poststuff #postbox-container-1 #side-sortables:empty {
     1442    #poststuff #postbox-container-1 .empty-container,
     1443    #poststuff #postbox-container-1 #side-sortables:empty {
    14441444        border: 0 none;
    14451445        height: 0;
     
    14471447    }
    14481448
    1449     .poststuff #post-body.columns-2 #side-sortables {
     1449    #poststuff #post-body.columns-2 #side-sortables {
    14501450        min-height: 0;
    14511451        width: auto;
     
    14721472    }
    14731473
    1474     .poststuff .stuffbox .inside {
     1474    #poststuff .stuffbox .inside {
    14751475        padding: 0 2px 4px 0;
    14761476    }
    14771477
    1478     .poststuff h3.hndle, /* Back-compat for pre-4.4 */
    1479     .poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
    1480     .poststuff h2 {
     1478    #poststuff h3.hndle, /* Back-compat for pre-4.4 */
     1479    #poststuff .stuffbox > h3, /* Back-compat for pre-4.4 */
     1480    #poststuff h2 {
    14811481        padding: 12px;
    14821482    }
  • trunk/src/wp-admin/css/ie.css

    r47222 r47410  
    1414}
    1515
    16 #wpbody-content #dashboard-widgets .postbox-container-2,
     16#wpbody-content #dashboard-widgets #postbox-container-2,
    1717#wpbody-content #dashboard-widgets #postbox-container-3,
    1818#wpbody-content #dashboard-widgets #postbox-container-4 {
     
    368368#postdivrich,
    369369#postdiv,
    370 .poststuff,
     370#poststuff,
    371371.metabox-holder,
    372372#titlediv,
     
    415415}
    416416
    417 .poststuff h2 {
     417#poststuff h2 {
    418418    font-size: 1.6em;
    419419}
    420420
    421 .poststuff .inside #parent_id,
    422 .poststuff .inside #page_template,
     421#poststuff .inside #parent_id,
     422#poststuff .inside #page_template,
    423423.inline-edit-row #post_parent,
    424424.inline-edit-row select[name="page_template"] {
     
    678678}
    679679
    680 * html .poststuff h2 {
     680* html #poststuff h2 {
    681681    margin-left: 0;
    682682}
  • trunk/src/wp-admin/css/media.css

    r47304 r47410  
    10341034}
    10351035
    1036 .poststuff .imgedit-group-top h2 {
     1036#poststuff .imgedit-group-top h2 {
    10371037    display: inline-block;
    10381038    margin: 0;
     
    10421042}
    10431043
    1044 .poststuff .imgedit-group-top .button-link {
     1044#poststuff .imgedit-group-top .button-link {
    10451045    text-decoration: none;
    10461046    color: #23282d;
  • trunk/src/wp-admin/edit-form-advanced.php

    r47372 r47410  
    495495?>
    496496
    497 <div class="poststuff">
     497<div id="poststuff">
    498498<div id="post-body" class="metabox-holder columns-<?php echo 1 == get_current_screen()->get_columns() ? '1' : '2'; ?>">
    499499<div id="post-body-content">
     
    672672?>
    673673</div>
    674 <div class="postbox-container-2 postbox-container">
     674<div id="postbox-container-2" class="postbox-container">
    675675<?php
    676676
  • trunk/src/wp-admin/edit-form-comment.php

    r47252 r47410  
    1717<h1><?php _e( 'Edit Comment' ); ?></h1>
    1818
    19 <div class="poststuff">
     19<div id="poststuff">
    2020<input type="hidden" name="action" value="editedcomment" />
    2121<input type="hidden" name="comment_ID" value="<?php echo esc_attr( $comment->comment_ID ); ?>" />
     
    215215</div>
    216216
    217 <div class="postbox-container-2 postbox-container">
     217<div id="postbox-container-2" class="postbox-container">
    218218<?php
    219219/** This action is documented in wp-admin/includes/meta-boxes.php */
  • trunk/src/wp-admin/edit-link-form.php

    r47222 r47410  
    107107?>
    108108
    109 <div class="poststuff">
     109<div id="poststuff">
    110110
    111111<div id="post-body" class="metabox-holder columns-<?php echo 1 == get_current_screen()->get_columns() ? '1' : '2'; ?>">
     
    145145?>
    146146</div>
    147 <div class="postbox-container-2 postbox-container">
     147<div id="postbox-container-2" class="postbox-container">
    148148<?php
    149149
  • trunk/src/wp-admin/includes/dashboard.php

    r47300 r47410  
    246246    <?php do_meta_boxes( $screen->id, 'normal', '' ); ?>
    247247    </div>
    248     <div class="postbox-container-2 postbox-container">
     248    <div id="postbox-container-2" class="postbox-container">
    249249    <?php do_meta_boxes( $screen->id, 'side', '' ); ?>
    250250    </div>
  • trunk/src/wp-admin/includes/post.php

    r47398 r47410  
    22762276    <?php foreach ( $locations as $location ) : ?>
    22772277        <form class="metabox-location-<?php echo esc_attr( $location ); ?>" onsubmit="return false;">
    2278             <div class="poststuff" class="sidebar-open">
    2279                 <div class="postbox-container-2 postbox-container">
     2278            <div id="poststuff" class="sidebar-open">
     2279                <div id="postbox-container-2" class="postbox-container">
    22802280                    <?php
    22812281                    do_meta_boxes(
Note: See TracChangeset for help on using the changeset viewer.