Changeset 47484

Timestamp:

03/22/2020 02:04:40 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Embeds: Remove the external oEmbed tests for YouTube.

These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.3 branch.
See #42076, #32714, #23149.

Location:

branches/4.3

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/media.php (modified) (1 diff)

branches/4.3/tests/phpunit/tests/media.php

@@ -113 +113 @@
         $this->assertTrue( wp_oembed_remove_provider( 'http://foo.bar/*' ) );
         $this->assertFalse( wp_oembed_remove_provider( 'http://foo.bar/*' ) );
-    }
-
-    /**
-     * Test secure youtube.com embeds
-     *
-     * @ticket 23149
-     */
-    function test_youtube_com_secure_embed() {
-        $out = wp_oembed_get( 'http://www.youtube.com/watch?v=oHg5SJYRHA0' );
-        $this->assertContains( 'https://www.youtube.com/embed/oHg5SJYRHA0?feature=oembed', $out );
-
-        $out = wp_oembed_get( 'https://www.youtube.com/watch?v=oHg5SJYRHA0' );
-        $this->assertContains( 'https://www.youtube.com/embed/oHg5SJYRHA0?feature=oembed', $out );
-
-        $out = wp_oembed_get( 'https://youtu.be/zHjMoNQN7s0' );
-        $this->assertContains( 'https://www.youtube.com/embed/zHjMoNQN7s0?feature=oembed', $out );
-    }
-
-    /**
-     * Test m.youtube.com embeds
-     *
-     * @ticket 32714
-     */
-    function test_youtube_com_mobile_embed() {
-        $out = wp_oembed_get( 'http://m.youtube.com/watch?v=oHg5SJYRHA0' );
-        $this->assertContains( 'https://www.youtube.com/embed/oHg5SJYRHA0?feature=oembed', $out );
-
-        $out = wp_oembed_get( 'https://m.youtube.com/watch?v=oHg5SJYRHA0' );
-        $this->assertContains( 'https://www.youtube.com/embed/oHg5SJYRHA0?feature=oembed', $out );
-    }
-
-    function test_youtube_embed_url() {
-        global $wp_embed;
-        $out = $wp_embed->autoembed( 'https://www.youtube.com/embed/QcIy9NiNbmo' );
-        $this->assertContains( 'https://youtube.com/watch?v=QcIy9NiNbmo', $out );
-    }
-
-    function test_youtube_v_url() {
-        global $wp_embed;
-        $out = $wp_embed->autoembed( 'https://www.youtube.com/v/QcIy9NiNbmo' );
-        $this->assertContains( 'https://youtube.com/watch?v=QcIy9NiNbmo', $out );
     }