Make WordPress Core


Ignore:
Timestamp:
04/05/2020 03:00:44 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/comment.php

    r47219 r47550  
    256256        $comment_id = absint( $_REQUEST['c'] );
    257257
    258         if ( in_array( $action, array( 'approvecomment', 'unapprovecomment' ) ) ) {
     258        if ( in_array( $action, array( 'approvecomment', 'unapprovecomment' ), true ) ) {
    259259            check_admin_referer( 'approve-comment_' . $comment_id );
    260260        } else {
     
    276276        } elseif ( '' != wp_get_original_referer() && ! $noredir ) {
    277277            $redir = wp_get_original_referer();
    278         } elseif ( in_array( $action, array( 'approvecomment', 'unapprovecomment' ) ) ) {
     278        } elseif ( in_array( $action, array( 'approvecomment', 'unapprovecomment' ), true ) ) {
    279279            $redir = admin_url( 'edit-comments.php?p=' . absint( $comment->comment_post_ID ) );
    280280        } else {
Note: See TracChangeset for help on using the changeset viewer.