Changeset 47550 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (5 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -977 +977 @@
     check_ajax_referer( "approve-comment_$id" );
 
-    if ( in_array( $current, array( 'unapproved', 'spam' ) ) ) {
+    if ( in_array( $current, array( 'unapproved', 'spam' ), true ) ) {
         $result = wp_set_comment_status( $comment, 'approve', true );
     } else {
@@ -1272 +1272 @@
     if ( empty( $post->post_status ) ) {
         wp_die( 1 );
-    } elseif ( in_array( $post->post_status, array( 'draft', 'pending', 'trash' ) ) ) {
+    } elseif ( in_array( $post->post_status, array( 'draft', 'pending', 'trash' ), true ) ) {
         wp_die( __( 'Error: You are replying to a comment on a draft post.' ) );
     }
@@ -2058 +2058 @@
 
     // Hack: wp_unique_post_slug() doesn't work for drafts, so we will fake that our post is published.
-    if ( ! empty( $data['post_name'] ) && in_array( $post['post_status'], array( 'draft', 'pending' ) ) ) {
+    if ( ! empty( $data['post_name'] ) && in_array( $post['post_status'], array( 'draft', 'pending' ), true ) ) {
         $post['post_status'] = 'publish';
         $data['post_name']   = wp_unique_post_slug( $data['post_name'], $post['ID'], $post['post_status'], $post['post_type'], $post['post_parent'] );
@@ -2526 +2526 @@
 
     // If the context is custom header or background, make sure the uploaded file is an image.
-    if ( isset( $post_data['context'] ) && in_array( $post_data['context'], array( 'custom-header', 'custom-background' ) ) ) {
+    if ( isset( $post_data['context'] ) && in_array( $post_data['context'], array( 'custom-header', 'custom-background' ), true ) ) {
         $wp_filetype = wp_check_filetype_and_ext( $_FILES['async-upload']['tmp_name'], $_FILES['async-upload']['name'] );
 
@@ -2853 +2853 @@
     $dismissed = array_filter( explode( ',', (string) get_user_meta( get_current_user_id(), 'dismissed_wp_pointers', true ) ) );
 
-    if ( in_array( $pointer, $dismissed ) ) {
+    if ( in_array( $pointer, $dismissed, true ) ) {
         wp_die( 0 );
     }