Changeset 47550 for trunk/src/wp-admin/includes/class-wp-comments-list-table.php

Timestamp:

04/05/2020 03:00:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -88 +88 @@
 
         $comment_status = isset( $_REQUEST['comment_status'] ) ? $_REQUEST['comment_status'] : 'all';
-        if ( ! in_array( $comment_status, array( 'all', 'mine', 'moderated', 'approved', 'spam', 'trash' ) ) ) {
+        if ( ! in_array( $comment_status, array( 'all', 'mine', 'moderated', 'approved', 'spam', 'trash' ), true ) ) {
             $comment_status = 'all';
         }
@@ -345 +345 @@
 
         $actions = array();
-        if ( in_array( $comment_status, array( 'all', 'approved' ) ) ) {
+        if ( in_array( $comment_status, array( 'all', 'approved' ), true ) ) {
             $actions['unapprove'] = __( 'Unapprove' );
         }
-        if ( in_array( $comment_status, array( 'all', 'moderated' ) ) ) {
+        if ( in_array( $comment_status, array( 'all', 'moderated' ), true ) ) {
             $actions['approve'] = __( 'Approve' );
         }
-        if ( in_array( $comment_status, array( 'all', 'moderated', 'approved', 'trash' ) ) ) {
+        if ( in_array( $comment_status, array( 'all', 'moderated', 'approved', 'trash' ), true ) ) {
             $actions['spam'] = _x( 'Mark as Spam', 'comment' );
         }
@@ -361 +361 @@
         }
 
-        if ( in_array( $comment_status, array( 'trash', 'spam' ) ) || ! EMPTY_TRASH_DAYS ) {
+        if ( in_array( $comment_status, array( 'trash', 'spam' ), true ) || ! EMPTY_TRASH_DAYS ) {
             $actions['delete'] = __( 'Delete Permanently' );
         } else {