Changeset 47550 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

04/05/2020 03:00:44 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -182 +182 @@
          */
         public function __get( $name ) {
-                if ( in_array( $name, $this->compat_fields ) ) {
+                if ( in_array( $name, $this->compat_fields, true ) ) {
                         return $this->$name;
                 }
@@ -197 +197 @@
          */
         public function __set( $name, $value ) {
-                if ( in_array( $name, $this->compat_fields ) ) {
+                if ( in_array( $name, $this->compat_fields, true ) ) {
                         return $this->$name = $value;
                 }
@@ -211 +211 @@
          */
         public function __isset( $name ) {
-                if ( in_array( $name, $this->compat_fields ) ) {
+                if ( in_array( $name, $this->compat_fields, true ) ) {
                         return isset( $this->$name );
                 }
@@ -224 +224 @@
          */
         public function __unset( $name ) {
-                if ( in_array( $name, $this->compat_fields ) ) {
+                if ( in_array( $name, $this->compat_fields, true ) ) {
                         unset( $this->$name );
                 }
@@ -239 +239 @@
          */
         public function __call( $name, $arguments ) {
-                if ( in_array( $name, $this->compat_methods ) ) {
+                if ( in_array( $name, $this->compat_methods, true ) ) {
                         return $this->$name( ...$arguments );
                 }
@@ -1134 +1134 @@
                         $class = array( 'manage-column', "column-$column_key" );
 
-                        if ( in_array( $column_key, $hidden ) ) {
+                        if ( in_array( $column_key, $hidden, true ) ) {
                                 $class[] = 'hidden';
                         }
@@ -1140 +1140 @@
                         if ( 'cb' === $column_key ) {
                                 $class[] = 'check-column';
-                        } elseif ( in_array( $column_key, array( 'posts', 'comments', 'links' ) ) ) {
+                        } elseif ( in_array( $column_key, array( 'posts', 'comments', 'links' ), true ) ) {
                                 $class[] = 'num';
                         }
@@ -1330 +1330 @@
                         }
 
-                        if ( in_array( $column_name, $hidden ) ) {
+                        if ( in_array( $column_name, $hidden, true ) ) {
                                 $classes .= ' hidden';
                         }