Changeset 47550 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -46 +46 @@
 
         $status = isset( $_REQUEST['theme_status'] ) ? $_REQUEST['theme_status'] : 'all';
-        if ( ! in_array( $status, array( 'all', 'enabled', 'disabled', 'upgrade', 'search', 'broken' ) ) ) {
+        if ( ! in_array( $status, array( 'all', 'enabled', 'disabled', 'upgrade', 'search', 'broken' ), true ) ) {
             $status = 'all';
         }
@@ -144 +144 @@
         }
 
-        if ( empty( $themes[ $status ] ) && ! in_array( $status, array( 'all', 'search' ) ) ) {
+        if ( empty( $themes[ $status ] ) && ! in_array( $status, array( 'all', 'search' ), true ) ) {
             $status = 'all';
         }
@@ -675 +675 @@
         foreach ( $columns as $column_name => $column_display_name ) {
             $extra_classes = '';
-            if ( in_array( $column_name, $hidden ) ) {
+            if ( in_array( $column_name, $hidden, true ) ) {
                 $extra_classes .= ' hidden';
             }