Make WordPress Core


Ignore:
Timestamp:
04/05/2020 03:00:44 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

    r47219 r47550  
    4646
    4747        $status = isset( $_REQUEST['theme_status'] ) ? $_REQUEST['theme_status'] : 'all';
    48         if ( ! in_array( $status, array( 'all', 'enabled', 'disabled', 'upgrade', 'search', 'broken' ) ) ) {
     48        if ( ! in_array( $status, array( 'all', 'enabled', 'disabled', 'upgrade', 'search', 'broken' ), true ) ) {
    4949            $status = 'all';
    5050        }
     
    144144        }
    145145
    146         if ( empty( $themes[ $status ] ) && ! in_array( $status, array( 'all', 'search' ) ) ) {
     146        if ( empty( $themes[ $status ] ) && ! in_array( $status, array( 'all', 'search' ), true ) ) {
    147147            $status = 'all';
    148148        }
     
    675675        foreach ( $columns as $column_name => $column_display_name ) {
    676676            $extra_classes = '';
    677             if ( in_array( $column_name, $hidden ) ) {
     677            if ( in_array( $column_name, $hidden, true ) ) {
    678678                $extra_classes .= ' hidden';
    679679            }
Note: See TracChangeset for help on using the changeset viewer.