Changeset 47550 for trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

Timestamp:

04/05/2020 03:00:44 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -40 +40 @@
                 );
 
+                $status_whitelist = array( 'active', 'inactive', 'recently_activated', 'upgrade', 'mustuse', 'dropins', 'search', 'paused' );
+
                 $status = 'all';
-                if ( isset( $_REQUEST['plugin_status'] ) && in_array( $_REQUEST['plugin_status'], array( 'active', 'inactive', 'recently_activated', 'upgrade', 'mustuse', 'dropins', 'search', 'paused' ) ) ) {
+                if ( isset( $_REQUEST['plugin_status'] ) && in_array( $_REQUEST['plugin_status'], $status_whitelist, true ) ) {
                         $status = $_REQUEST['plugin_status'];
                 }
@@ -244 +246 @@
                 }
 
-                if ( empty( $plugins[ $status ] ) && ! in_array( $status, array( 'all', 'search' ) ) ) {
+                if ( empty( $plugins[ $status ] ) && ! in_array( $status, array( 'all', 'search' ), true ) ) {
                         $status = 'all';
                 }
@@ -399 +401 @@
 
                 return array(
-                        'cb'          => ! in_array( $status, array( 'mustuse', 'dropins' ) ) ? '<input type="checkbox" />' : '',
+                        'cb'          => ! in_array( $status, array( 'mustuse', 'dropins' ), true ) ? '<input type="checkbox" />' : '',
                         'name'        => __( 'Plugin' ),
                         'description' => __( 'Description' ),
@@ -543 +545 @@
                 global $status;
 
-                if ( in_array( $status, array( 'mustuse', 'dropins' ) ) ) {
+                if ( in_array( $status, array( 'mustuse', 'dropins' ), true ) ) {
                         return;
                 }
@@ -557 +559 @@
                 global $status;
 
-                if ( ! in_array( $status, array( 'recently_activated', 'mustuse', 'dropins' ) ) ) {
+                if ( ! in_array( $status, array( 'recently_activated', 'mustuse', 'dropins' ), true ) ) {
                         return;
                 }
@@ -598 +600 @@
                 global $status;
 
-                if ( is_multisite() && ! $this->screen->in_admin( 'network' ) && in_array( $status, array( 'mustuse', 'dropins' ) ) ) {
+                if ( is_multisite() && ! $this->screen->in_admin( 'network' ) && in_array( $status, array( 'mustuse', 'dropins' ), true ) ) {
                         return;
                 }
@@ -832 +834 @@
                 $class          = $is_active ? 'active' : 'inactive';
                 $checkbox_id    = 'checkbox_' . md5( $plugin_data['Name'] );
-                if ( $restrict_network_active || $restrict_network_only || in_array( $status, array( 'mustuse', 'dropins' ) ) || ! $compatible_php ) {
+                if ( $restrict_network_active || $restrict_network_only || in_array( $status, array( 'mustuse', 'dropins' ), true ) || ! $compatible_php ) {
                         $checkbox = '';
                 } else {
@@ -871 +873 @@
                 foreach ( $columns as $column_name => $column_display_name ) {
                         $extra_classes = '';
-                        if ( in_array( $column_name, $hidden ) ) {
+                        if ( in_array( $column_name, $hidden, true ) ) {
                                 $extra_classes = ' hidden';
                         }