Changeset 47550 for trunk/src/wp-admin/includes/class-wp-posts-list-table.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -162 +162 @@
             $post_counts = (array) wp_count_posts( $post_type, 'readable' );
 
-            if ( isset( $_REQUEST['post_status'] ) && in_array( $_REQUEST['post_status'], $avail_post_stati ) ) {
+            if ( isset( $_REQUEST['post_status'] ) && in_array( $_REQUEST['post_status'], $avail_post_stati, true ) ) {
                 $total_items = $post_counts[ $_REQUEST['post_status'] ];
             } elseif ( isset( $_REQUEST['show_sticky'] ) && $_REQUEST['show_sticky'] ) {
@@ -347 +347 @@
             $status_name = $status->name;
 
-            if ( ! in_array( $status_name, $avail_post_stati ) || empty( $num_posts->$status_name ) ) {
+            if ( ! in_array( $status_name, $avail_post_stati, true ) || empty( $num_posts->$status_name ) ) {
                 continue;
             }
@@ -392 +392 @@
 
             // Sticky comes after Publish, or if not listed, after All.
-            $split        = 1 + array_search( ( isset( $status_links['publish'] ) ? 'publish' : 'all' ), array_keys( $status_links ) );
+            $split        = 1 + array_search( ( isset( $status_links['publish'] ) ? 'publish' : 'all' ), array_keys( $status_links ), true );
             $status_links = array_merge( array_slice( $status_links, 0, $split ), $sticky_link, array_slice( $status_links, $split ) );
         }
@@ -647 +647 @@
 
         $post_status = ! empty( $_REQUEST['post_status'] ) ? $_REQUEST['post_status'] : 'all';
-        if ( post_type_supports( $post_type, 'comments' ) && ! in_array( $post_status, array( 'pending', 'draft', 'future' ) ) ) {
+        if ( post_type_supports( $post_type, 'comments' ) && ! in_array( $post_status, array( 'pending', 'draft', 'future' ), true ) ) {
             $posts_columns['comments'] = '<span class="vers comment-grey-bubble" title="' . esc_attr__( 'Comments' ) . '"><span class="screen-reader-text">' . __( 'Comments' ) . '</span></span>';
         }
@@ -1385 +1385 @@
 
         if ( is_post_type_viewable( $post_type_object ) ) {
-            if ( in_array( $post->post_status, array( 'pending', 'draft', 'future' ) ) ) {
+            if ( in_array( $post->post_status, array( 'pending', 'draft', 'future' ), true ) ) {
                 if ( $can_edit_post ) {
                     $preview_link    = get_preview_post_link( $post );