Changeset 47550 for trunk/src/wp-admin/includes/class-wp-screen.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/class-wp-screen.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -1158 +1158 @@
         foreach ( $columns as $column => $title ) {
             // Can't hide these for they are special.
-            if ( in_array( $column, $special ) ) {
+            if ( in_array( $column, $special, true ) ) {
                 continue;
             }
@@ -1175 +1175 @@
             $id = "$column-hide";
             echo '<label>';
-            echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '"' . checked( ! in_array( $column, $hidden ), true, false ) . ' />';
+            echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '"' . checked( ! in_array( $column, $hidden, true ), true, false ) . ' />';
             echo "$title</label>\n";
         }
@@ -1311 +1311 @@
         $view_mode_post_types = apply_filters( 'view_mode_post_types', $view_mode_post_types );
 
-        if ( ! in_array( $this->post_type, $view_mode_post_types ) ) {
+        if ( ! in_array( $this->post_type, $view_mode_post_types, true ) ) {
             return;
         }