Changeset 47550 for trunk/src/wp-admin/includes/meta-boxes.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/meta-boxes.php (modified) (6 diffs)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -335 +335 @@
 <span class="spinner"></span>
     <?php
-    if ( ! in_array( $post->post_status, array( 'publish', 'future', 'private' ) ) || 0 == $post->ID ) {
+    if ( ! in_array( $post->post_status, array( 'publish', 'future', 'private' ), true ) || 0 == $post->ID ) {
         if ( $can_publish ) :
             if ( ! empty( $post->post_date_gmt ) && time() < strtotime( $post->post_date_gmt . ' +0000' ) ) :
@@ -472 +472 @@
             }
             // Add in the current one if it isn't there yet, in case the current theme doesn't support it.
-            if ( $post_format && ! in_array( $post_format, $post_formats[0] ) ) {
+            if ( $post_format && ! in_array( $post_format, $post_formats[0], true ) ) {
                 $post_formats[0][] = $post_format;
             }
@@ -848 +848 @@
     } else {
         $hidden = get_hidden_meta_boxes( get_current_screen() );
-        if ( ! in_array( 'commentsdiv', $hidden ) ) {
+        if ( ! in_array( 'commentsdiv', $hidden, true ) ) {
             ?>
             <script type="text/javascript">jQuery(document).ready(function(){commentsBox.get(<?php echo $total; ?>, 10);});</script>
@@ -1183 +1183 @@
     $rels     = preg_split( '/\s+/', $link_rel );
 
-    if ( '' != $value && in_array( $value, $rels ) ) {
+    if ( '' != $value && in_array( $value, $rels, true ) ) {
         echo ' checked="checked"';
     }
@@ -1197 +1197 @@
             echo ' checked="checked"';
         }
-        if ( 'identity' == $class && in_array( 'me', $rels ) ) {
+        if ( 'identity' == $class && in_array( 'me', $rels, true ) ) {
             echo ' checked="checked"';
         }
@@ -1536 +1536 @@
     $stati[] = 'private';
 
-    if ( in_array( get_post_status( $post ), $stati ) ) {
+    if ( in_array( get_post_status( $post ), $stati, true ) ) {
         // If the post type support comments, or the post has comments,
         // allow the Comments meta box.