Changeset 47550 for trunk/src/wp-admin/includes/misc.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/misc.php (modified) (3 diffs)

trunk/src/wp-admin/includes/misc.php

@@ -600 +600 @@
         if ( T_STRING == $tokens[ $t ][0] && ( '(' == $tokens[ $t + 1 ] || '(' == $tokens[ $t + 2 ] ) ) {
             // If it's a function or class defined locally, there's not going to be any docs available.
-            if ( ( isset( $tokens[ $t - 2 ][1] ) && in_array( $tokens[ $t - 2 ][1], array( 'function', 'class' ) ) ) || ( isset( $tokens[ $t - 2 ][0] ) && T_OBJECT_OPERATOR == $tokens[ $t - 1 ][0] ) ) {
+            if ( ( isset( $tokens[ $t - 2 ][1] ) && in_array( $tokens[ $t - 2 ][1], array( 'function', 'class' ), true ) )
+                || ( isset( $tokens[ $t - 2 ][0] ) && T_OBJECT_OPERATOR == $tokens[ $t - 1 ][0] )
+            ) {
                 $ignore_functions[] = $tokens[ $t ][1];
             }
@@ -624 +626 @@
     $out = array();
     foreach ( $functions as $function ) {
-        if ( in_array( $function, $ignore_functions ) ) {
+        if ( in_array( $function, $ignore_functions, true ) ) {
             continue;
         }
@@ -657 +659 @@
         $type       = str_replace( 'edit_', '', $map_option );
         $type       = str_replace( '_per_page', '', $type );
-        if ( in_array( $type, get_taxonomies() ) ) {
+        if ( in_array( $type, get_taxonomies(), true ) ) {
             $map_option = 'edit_tags_per_page';
-        } elseif ( in_array( $type, get_post_types() ) ) {
+        } elseif ( in_array( $type, get_post_types(), true ) ) {
             $map_option = 'edit_per_page';
         } else {