Changeset 47550 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (3 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -524 +524 @@
  */
 function is_plugin_active( $plugin ) {
-    return in_array( $plugin, (array) get_option( 'active_plugins', array() ) ) || is_plugin_active_for_network( $plugin );
+    return in_array( $plugin, (array) get_option( 'active_plugins', array() ), true ) || is_plugin_active_for_network( $plugin );
 }
 
@@ -645 +645 @@
     }
 
-    if ( ( $network_wide && ! isset( $current[ $plugin ] ) ) || ( ! $network_wide && ! in_array( $plugin, $current ) ) ) {
+    if ( ( $network_wide && ! isset( $current[ $plugin ] ) ) || ( ! $network_wide && ! in_array( $plugin, $current, true ) ) ) {
         if ( ! empty( $redirect ) ) {
             // We'll override this later if the plugin can be included without fatal error.
@@ -784 +784 @@
 
         if ( true !== $network_wide ) {
-            $key = array_search( $plugin, $current );
+            $key = array_search( $plugin, $current, true );
             if ( false !== $key ) {
                 $do_blog = true;