Changeset 47550 for trunk/src/wp-admin/includes/post.php

Timestamp:

04/05/2020 03:00:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/post.php (modified) (9 diffs)

trunk/src/wp-admin/includes/post.php

@@ -135 +135 @@
     // Posts 'submitted for approval' are submitted to $_POST the same as if they were being published.
     // Change status from 'publish' to 'pending' if user lacks permissions to publish or to resave published posts.
-    if ( isset( $post_data['post_status'] ) && ( in_array( $post_data['post_status'], $published_statuses ) && ! current_user_can( $ptype->cap->publish_posts ) ) ) {
-        if ( ! in_array( $previous_status, $published_statuses ) || ! current_user_can( 'edit_post', $post_id ) ) {
+    if ( isset( $post_data['post_status'] )
+        && ( in_array( $post_data['post_status'], $published_statuses, true )
+        && ! current_user_can( $ptype->cap->publish_posts ) )
+    ) {
+        if ( ! in_array( $previous_status, $published_statuses, true ) || ! current_user_can( 'edit_post', $post_id ) ) {
             $post_data['post_status'] = 'pending';
         }
@@ -565 +568 @@
         $post_type_object = get_post_type_object( get_post_type( $post_ID ) );
 
-        if ( ! isset( $post_type_object ) || ( isset( $children ) && in_array( $post_ID, $children ) ) || ! current_user_can( 'edit_post', $post_ID ) ) {
+        if ( ! isset( $post_type_object )
+            || ( isset( $children ) && in_array( $post_ID, $children ) )
+            || ! current_user_can( 'edit_post', $post_ID )
+        ) {
             $skipped[] = $post_ID;
             continue;
@@ -594 +600 @@
         }
 
-        if ( isset( $new_cats ) && in_array( 'category', $tax_names ) ) {
+        if ( isset( $new_cats ) && in_array( 'category', $tax_names, true ) ) {
             $cats                       = (array) wp_get_post_categories( $post_ID );
             $post_data['post_category'] = array_unique( array_merge( $cats, $new_cats ) );
@@ -1038 +1044 @@
 
     // Don't run if no pretty permalinks or post is not published, scheduled, or privately published.
-    if ( ! get_option( 'permalink_structure' ) || ! in_array( $post['post_status'], array( 'publish', 'future', 'private' ) ) ) {
+    if ( ! get_option( 'permalink_structure' ) || ! in_array( $post['post_status'], array( 'publish', 'future', 'private' ), true ) ) {
         return;
     }
@@ -1111 +1117 @@
     $post_stati = get_post_stati();
 
-    if ( isset( $q['post_type'] ) && in_array( $q['post_type'], get_post_types() ) ) {
+    if ( isset( $q['post_type'] ) && in_array( $q['post_type'], get_post_types(), true ) ) {
         $post_type = $q['post_type'];
     } else {
@@ -1121 +1127 @@
     $perm             = '';
 
-    if ( isset( $q['post_status'] ) && in_array( $q['post_status'], $post_stati ) ) {
+    if ( isset( $q['post_status'] ) && in_array( $q['post_status'], $post_stati, true ) ) {
         $post_status = $q['post_status'];
         $perm        = 'readable';
@@ -1130 +1136 @@
     if ( isset( $q['orderby'] ) ) {
         $orderby = $q['orderby'];
-    } elseif ( isset( $q['post_status'] ) && in_array( $q['post_status'], array( 'pending', 'draft' ) ) ) {
+    } elseif ( isset( $q['post_status'] ) && in_array( $q['post_status'], array( 'pending', 'draft' ), true ) ) {
         $orderby = 'modified';
     }
@@ -1295 +1301 @@
             $classes = array( '' );
         } else {
-            $classes = in_array( $box_id, $closed ) ? array( 'closed' ) : array( '' );
+            $classes = in_array( $box_id, $closed, true ) ? array( 'closed' ) : array( '' );
         }
     } else {
@@ -1343 +1349 @@
 
     // Hack: get_permalink() would return ugly permalink for drafts, so we will fake that our post is published.
-    if ( in_array( $post->post_status, array( 'draft', 'pending', 'future' ) ) ) {
+    if ( in_array( $post->post_status, array( 'draft', 'pending', 'future' ), true ) ) {
         $post->post_status = 'publish';
         $post->post_name   = sanitize_title( $post->post_name ? $post->post_name : $post->post_title, $post->ID );