Changeset 47550 for trunk/src/wp-admin/includes/schema.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/schema.php (modified) (3 diffs)

trunk/src/wp-admin/includes/schema.php

@@ -401 +401 @@
     if ( is_numeric( $offset_or_tz ) ) {
         $gmt_offset = $offset_or_tz;
-    } elseif ( $offset_or_tz && in_array( $offset_or_tz, timezone_identifiers_list() ) ) {
+    } elseif ( $offset_or_tz && in_array( $offset_or_tz, timezone_identifiers_list(), true ) ) {
             $timezone_string = $offset_or_tz;
     }
@@ -564 +564 @@
 
     $insert = '';
+
     foreach ( $options as $option => $value ) {
-        if ( in_array( $option, $existing_options ) ) {
+        if ( in_array( $option, $existing_options, true ) ) {
             continue;
         }
-        if ( in_array( $option, $fat_options ) ) {
+
+        if ( in_array( $option, $fat_options, true ) ) {
             $autoload = 'no';
         } else {
@@ -577 +579 @@
             $value = serialize( $value );
         }
+
         if ( ! empty( $insert ) ) {
             $insert .= ', ';
         }
+
         $insert .= $wpdb->prepare( '(%s, %s, %s)', $option, $value, $autoload );
     }