Changeset 47550 for trunk/src/wp-admin/includes/template.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/template.php (modified) (5 diffs)

trunk/src/wp-admin/includes/template.php

@@ -784 +784 @@
 
     if ( $for_post ) {
-        $edit = ! ( in_array( $post->post_status, array( 'draft', 'pending' ) ) && ( ! $post->post_date_gmt || '0000-00-00 00:00:00' == $post->post_date_gmt ) );
+        $edit = ! ( in_array( $post->post_status, array( 'draft', 'pending' ), true ) && ( ! $post->post_date_gmt || '0000-00-00 00:00:00' == $post->post_date_gmt ) );
     }
 
@@ -1298 +1298 @@
                     $i++;
                     // get_hidden_meta_boxes() doesn't apply in the block editor.
-                    $hidden_class = ( ! $screen->is_block_editor() && in_array( $box['id'], $hidden ) ) ? ' hide-if-js' : '';
+                    $hidden_class = ( ! $screen->is_block_editor() && in_array( $box['id'], $hidden, true ) ) ? ' hide-if-js' : '';
                     echo '<div id="' . $box['id'] . '" class="postbox ' . postbox_classes( $box['id'], $page ) . $hidden_class . '" ' . '>' . "\n";
                     if ( 'dashboard_browser_nag' != $box['id'] ) {
@@ -1454 +1454 @@
                     }
                     $i++;
-                    $hidden_class = in_array( $box['id'], $hidden ) ? 'hide-if-js' : '';
+                    $hidden_class = in_array( $box['id'], $hidden, true ) ? 'hide-if-js' : '';
 
                     $open_class = '';
@@ -1839 +1839 @@
         }
 
-        if ( in_array( $details['type'], array( 'error', 'success', 'warning', 'info' ) ) ) {
+        if ( in_array( $details['type'], array( 'error', 'success', 'warning', 'info' ), true ) ) {
             $details['type'] = 'notice-' . $details['type'];
         }
@@ -2374 +2374 @@
             continue;
         }
-        $classes[] = in_array( $t, $button_shorthand ) ? 'button-' . $t : $t;
+        $classes[] = in_array( $t, $button_shorthand, true ) ? 'button-' . $t : $t;
     }
     // Remove empty items, remove duplicate items, and finally build a string.