Changeset 47550 for trunk/src/wp-admin/includes/translation-install.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/translation-install.php (modified) (4 diffs)

trunk/src/wp-admin/includes/translation-install.php

@@ -21 +21 @@
     require ABSPATH . WPINC . '/version.php';
 
-    if ( ! in_array( $type, array( 'plugins', 'themes', 'core' ) ) ) {
+    if ( ! in_array( $type, array( 'plugins', 'themes', 'core' ), true ) ) {
         return new WP_Error( 'invalid_type', __( 'Invalid translation type.' ) );
     }
@@ -177 +177 @@
                 esc_attr( current( $language['iso'] ) ),
                 esc_attr( $language['strings']['continue'] ?: 'Continue' ),
-                in_array( $language['language'], $installed_languages ) ? ' data-installed="1"' : '',
+                in_array( $language['language'], $installed_languages, true ) ? ' data-installed="1"' : '',
                 esc_html( $language['native_name'] )
             );
@@ -191 +191 @@
             esc_attr( current( $language['iso'] ) ),
             esc_attr( $language['strings']['continue'] ?: 'Continue' ),
-            in_array( $language['language'], $installed_languages ) ? ' data-installed="1"' : '',
+            in_array( $language['language'], $installed_languages, true ) ? ' data-installed="1"' : '',
             esc_html( $language['native_name'] )
         );
@@ -212 +212 @@
 function wp_download_language_pack( $download ) {
     // Check if the translation is already installed.
-    if ( in_array( $download, get_available_languages() ) ) {
+    if ( in_array( $download, get_available_languages(), true ) ) {
         return $download;
     }