Changeset 47550 for trunk/src/wp-admin/includes/widgets.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/includes/widgets.php (modified) (1 diff)

trunk/src/wp-admin/includes/widgets.php

@@ -193 +193 @@
     $widget_id  = $sidebar_args['widget_id'];
     $sidebar_id = isset( $sidebar_args['id'] ) ? $sidebar_args['id'] : false;
-    $key        = $sidebar_id ? array_search( $widget_id, $sidebars_widgets[ $sidebar_id ] ) : '-1'; // Position of widget in sidebar.
+    $key        = $sidebar_id ? array_search( $widget_id, $sidebars_widgets[ $sidebar_id ], true ) : '-1'; // Position of widget in sidebar.
     $control    = isset( $wp_registered_widget_controls[ $widget_id ] ) ? $wp_registered_widget_controls[ $widget_id ] : array();
     $widget     = $wp_registered_widgets[ $widget_id ];