Changeset 47550 for trunk/src/wp-admin/menu.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/menu.php (modified) (3 diffs)

trunk/src/wp-admin/menu.php

@@ -136 +136 @@
             $menu_icon = esc_url( $ptype_obj->menu_icon );
         }
-    } elseif ( in_array( $ptype, $builtin ) ) {
+    } elseif ( in_array( $ptype, $builtin, true ) ) {
         $menu_icon = 'dashicons-admin-' . $ptype;
     }
@@ -153 +153 @@
     }
 
-    if ( in_array( $ptype, $builtin ) ) {
+    if ( in_array( $ptype, $builtin, true ) ) {
         $ptype_menu_id = 'menu-' . $ptype_for_id . 's';
     } else {
@@ -163 +163 @@
      */
     $core_menu_positions = array( 59, 60, 65, 70, 75, 80, 85, 99 );
-    while ( isset( $menu[ $ptype_menu_position ] ) || in_array( $ptype_menu_position, $core_menu_positions ) ) {
+    while ( isset( $menu[ $ptype_menu_position ] ) || in_array( $ptype_menu_position, $core_menu_positions, true ) ) {
         $ptype_menu_position++;
     }