Changeset 47550 for trunk/src/wp-admin/network/site-settings.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/network/site-settings.php (modified) (2 diffs)

trunk/src/wp-admin/network/site-settings.php

@@ -44 +44 @@
         $key = wp_unslash( $key );
         $val = wp_unslash( $val );
-        if ( 0 === $key || is_array( $val ) || in_array( $key, $skip_options ) ) {
+        if ( 0 === $key || is_array( $val ) || in_array( $key, $skip_options, true ) ) {
             continue; // Avoids "0 is a protected WP option and may not be modified" error when edit blog options.
         }
@@ -150 +150 @@
                 <tr class="form-field">
                     <th scope="row"><label for="<?php echo esc_attr( $option->option_name ); ?>"><?php echo esc_html( ucwords( str_replace( '_', ' ', $option->option_name ) ) ); ?></label></th>
-                    <?php if ( $is_main_site && in_array( $option->option_name, array( 'siteurl', 'home' ) ) ) { ?>
+                    <?php if ( $is_main_site && in_array( $option->option_name, array( 'siteurl', 'home' ), true ) ) { ?>
                     <td><code><?php echo esc_html( $option->option_value ); ?></code></td>
                     <?php } else { ?>