Changeset 47550 for trunk/src/wp-admin/options-general.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/options-general.php (modified) (3 diffs)

trunk/src/wp-admin/options-general.php

@@ -158 +158 @@
 $languages    = get_available_languages();
 $translations = wp_get_available_translations();
-if ( ! is_multisite() && defined( 'WPLANG' ) && '' !== WPLANG && 'en_US' !== WPLANG && ! in_array( WPLANG, $languages ) ) {
+if ( ! is_multisite() && defined( 'WPLANG' ) && '' !== WPLANG && 'en_US' !== WPLANG && ! in_array( WPLANG, $languages, true ) ) {
     $languages[] = WPLANG;
 }
@@ -168 +168 @@
             <?php
             $locale = get_locale();
-            if ( ! in_array( $locale, $languages ) ) {
+            if ( ! in_array( $locale, $languages, true ) ) {
                 $locale = '';
             }
@@ -277 +277 @@
     <br />
     <?php
-    if ( in_array( $tzstring, timezone_identifiers_list() ) ) {
+    if ( in_array( $tzstring, timezone_identifiers_list(), true ) ) {
         $transitions = timezone_transitions_get( timezone_open( $tzstring ), time() );