Changeset 47550 for trunk/src/wp-admin/plugin-editor.php

Timestamp:

04/05/2020 03:00:44 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/plugin-editor.php (modified) (3 diffs)

trunk/src/wp-admin/plugin-editor.php

@@ -113 +113 @@
                 $ext = strtolower( $matches[1] );
                 // If extension is not in the acceptable list, skip it.
-                if ( ! in_array( $ext, $editable_extensions ) ) {
+                if ( ! in_array( $ext, $editable_extensions, true ) ) {
                         wp_die( sprintf( '<p>%s</p>', __( 'Files of this type are not editable.' ) ) );
                 }
@@ -245 +245 @@
         $plugin_editable_files = array();
         foreach ( $plugin_files as $plugin_file ) {
-                if ( preg_match( '/\.([^.]+)$/', $plugin_file, $matches ) && in_array( $matches[1], $editable_extensions ) ) {
+                if ( preg_match( '/\.([^.]+)$/', $plugin_file, $matches ) && in_array( $matches[1], $editable_extensions, true ) ) {
                         $plugin_editable_files[] = $plugin_file;
                 }
@@ -278 +278 @@
         <?php if ( is_writeable( $real_file ) ) : ?>
                 <div class="editor-notices">
-                <?php if ( in_array( $plugin, (array) get_option( 'active_plugins', array() ) ) ) { ?>
+                <?php if ( in_array( $plugin, (array) get_option( 'active_plugins', array() ), true ) ) { ?>
                         <div class="notice notice-warning inline active-plugin-edit-warning">
                                 <p><?php _e( '<strong>Warning:</strong> Making changes to active plugins is not recommended.' ); ?></p>