Changeset 47550 for trunk/src/wp-admin/upload.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-admin/upload.php (modified) (2 diffs)

trunk/src/wp-admin/upload.php

@@ -17 +17 @@
 $modes = array( 'grid', 'list' );
 
-if ( isset( $_GET['mode'] ) && in_array( $_GET['mode'], $modes ) ) {
+if ( isset( $_GET['mode'] ) && in_array( $_GET['mode'], $modes, true ) ) {
     $mode = $_GET['mode'];
     update_user_option( get_current_user_id(), 'media_library_mode', $mode );
@@ -35 +35 @@
     $ignore = array( 'mode', 'post_type', 'post_status', 'posts_per_page' );
     foreach ( $vars as $key => $value ) {
-        if ( ! $value || in_array( $key, $ignore ) ) {
+        if ( ! $value || in_array( $key, $ignore, true ) ) {
             unset( $vars[ $key ] );
         }