Changeset 47550 for trunk/src/wp-includes/bookmark.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/bookmark.php (modified) (3 diffs)

trunk/src/wp-includes/bookmark.php

@@ -280 +280 @@
                 $ordparam = trim( $ordparam );
 
-                if ( in_array( 'link_' . $ordparam, $keys ) ) {
+                if ( in_array( 'link_' . $ordparam, $keys, true ) ) {
                     $orderparams[] = 'link_' . $ordparam;
-                } elseif ( in_array( $ordparam, $keys ) ) {
+                } elseif ( in_array( $ordparam, $keys, true ) ) {
                     $orderparams[] = $ordparam;
                 }
@@ -294 +294 @@
 
     $order = strtoupper( $parsed_args['order'] );
-    if ( '' !== $order && ! in_array( $order, array( 'ASC', 'DESC' ) ) ) {
+    if ( '' !== $order && ! in_array( $order, array( 'ASC', 'DESC' ), true ) ) {
         $order = 'ASC';
     }
@@ -413 +413 @@
         case 'link_target': // "enum"
             $targets = array( '_top', '_blank' );
-            if ( ! in_array( $value, $targets ) ) {
+            if ( ! in_array( $value, $targets, true ) ) {
                 $value = '';
             }