Changeset 47550 for trunk/src/wp-includes/capabilities.php

Timestamp:

04/05/2020 03:00:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/capabilities.php (modified) (3 diffs)

trunk/src/wp-includes/capabilities.php

@@ -880 +880 @@
     if ( is_multisite() ) {
         $super_admins = get_super_admins();
-        if ( is_array( $super_admins ) && in_array( $user->user_login, $super_admins ) ) {
+        if ( is_array( $super_admins ) && in_array( $user->user_login, $super_admins, true ) ) {
             return true;
         }
@@ -922 +922 @@
 
     $user = get_userdata( $user_id );
-    if ( $user && ! in_array( $user->user_login, $super_admins ) ) {
+    if ( $user && ! in_array( $user->user_login, $super_admins, true ) ) {
         $super_admins[] = $user->user_login;
         update_site_option( 'site_admins', $super_admins );
@@ -970 +970 @@
     $user = get_userdata( $user_id );
     if ( $user && 0 !== strcasecmp( $user->user_email, get_site_option( 'admin_email' ) ) ) {
-        $key = array_search( $user->user_login, $super_admins );
+        $key = array_search( $user->user_login, $super_admins, true );
         if ( false !== $key ) {
             unset( $super_admins[ $key ] );