Changeset 47550 for trunk/src/wp-includes/class-wp-comment-query.php

Timestamp:

04/05/2020 03:00:44 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -517 +517 @@
 
         // 'any' overrides other statuses.
-        if ( ! in_array( 'any', $statuses ) ) {
+        if ( ! in_array( 'any', $statuses, true ) ) {
             foreach ( $statuses as $status ) {
                 switch ( $status ) {
@@ -596 +596 @@
                 }
 
-                if ( ! $found_orderby_comment_id && in_array( $_orderby, array( 'comment_ID', 'comment__in' ) ) ) {
+                if ( ! $found_orderby_comment_id && in_array( $_orderby, array( 'comment_ID', 'comment__in' ), true ) ) {
                     $found_orderby_comment_id = true;
                 }
@@ -1146 +1146 @@
             $comment__in = implode( ',', array_map( 'absint', $this->query_vars['comment__in'] ) );
             $parsed      = "FIELD( {$wpdb->comments}.comment_ID, $comment__in )";
-        } elseif ( in_array( $orderby, $allowed_keys ) ) {
+        } elseif ( in_array( $orderby, $allowed_keys, true ) ) {
 
             if ( isset( $meta_query_clauses[ $orderby ] ) ) {