Changeset 47550 for trunk/src/wp-includes/class-wp-customize-widgets.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-customize-widgets.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-customize-widgets.php

@@ -451 +451 @@
                         'title'       => $wp_registered_sidebars[ $sidebar_id ]['name'],
                         'description' => $wp_registered_sidebars[ $sidebar_id ]['description'],
-                        'priority'    => array_search( $sidebar_id, array_keys( $wp_registered_sidebars ) ),
+                        'priority'    => array_search( $sidebar_id, array_keys( $wp_registered_sidebars ), true ),
                         'panel'       => 'widgets',
                         'sidebar_id'  => $sidebar_id,
@@ -578 +578 @@
         $parsed_widget_id = $this->parse_widget_id( $widget_id );
         $width            = $wp_registered_widget_controls[ $widget_id ]['width'];
-        $is_core          = in_array( $parsed_widget_id['id_base'], $this->core_widget_id_bases );
+        $is_core          = in_array( $parsed_widget_id['id_base'], $this->core_widget_id_bases, true );
         $is_wide          = ( $width > 250 && ! $is_core );
 
@@ -1221 +1221 @@
      */
     public function is_widget_rendered( $widget_id ) {
-        return in_array( $widget_id, $this->rendered_widgets );
+        return in_array( $widget_id, $this->rendered_widgets, true );
     }
 
@@ -1233 +1233 @@
      */
     public function is_sidebar_rendered( $sidebar_id ) {
-        return in_array( $sidebar_id, $this->rendered_sidebars );
+        return in_array( $sidebar_id, $this->rendered_sidebars, true );
     }