Changeset 47550 for trunk/src/wp-includes/class-wp-date-query.php

Timestamp:

04/05/2020 03:00:44 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-date-query.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-date-query.php

@@ -260 +260 @@
          */
         public function get_compare( $query ) {
-                if ( ! empty( $query['compare'] ) && in_array( $query['compare'], array( '=', '!=', '>', '>=', '<', '<=', 'IN', 'NOT IN', 'BETWEEN', 'NOT BETWEEN' ) ) ) {
+                if ( ! empty( $query['compare'] )
+                        && in_array( $query['compare'], array( '=', '!=', '>', '>=', '<', '<=', 'IN', 'NOT IN', 'BETWEEN', 'NOT BETWEEN' ), true )
+                ) {
                         return strtoupper( $query['compare'] );
                 }
@@ -501 +503 @@
                          *                                'user_registered'
                          */
-                        if ( ! in_array( $column, apply_filters( 'date_query_valid_columns', $valid_columns ) ) ) {
+                        if ( ! in_array( $column, apply_filters( 'date_query_valid_columns', $valid_columns ), true ) ) {
                                 $column = 'post_date';
                         }
@@ -527 +529 @@
                         // If it's a known column name, add the appropriate table prefix.
                         foreach ( $known_columns as $table_name => $table_columns ) {
-                                if ( in_array( $column, $table_columns ) ) {
+                                if ( in_array( $column, $table_columns, true ) ) {
                                         $column = $table_name . '.' . $column;
                                         break;
@@ -973 +975 @@
 
                 // Complex combined queries aren't supported for multi-value queries.
-                if ( in_array( $compare, array( 'IN', 'NOT IN', 'BETWEEN', 'NOT BETWEEN' ) ) ) {
+                if ( in_array( $compare, array( 'IN', 'NOT IN', 'BETWEEN', 'NOT BETWEEN' ), true ) ) {
                         $return = array();