Changeset 47550 for trunk/src/wp-includes/class-wp-embed.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-embed.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-embed.php

@@ -371 +371 @@
 
         $post_types = get_post_types( array( 'show_ui' => true ) );
+
         /**
          * Filters the array of post types to cache oEmbed results for.
@@ -378 +379 @@
          * @param string[] $post_types Array of post type names to cache oEmbed results for. Defaults to post types with `show_ui` set to true.
          */
-        if ( empty( $post->ID ) || ! in_array( $post->post_type, apply_filters( 'embed_cache_oembed_types', $post_types ) ) ) {
+        $cache_oembed_types = apply_filters( 'embed_cache_oembed_types', $post_types );
+
+        if ( empty( $post->ID ) || ! in_array( $post->post_type, $cache_oembed_types, true ) ) {
             return;
         }