Changeset 47550 for trunk/src/wp-includes/class-wp-meta-query.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-meta-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-meta-query.php

@@ -688 +688 @@
             $meta_value = $clause['value'];
 
-            if ( in_array( $meta_compare, array( 'IN', 'NOT IN', 'BETWEEN', 'NOT BETWEEN' ) ) ) {
+            if ( in_array( $meta_compare, array( 'IN', 'NOT IN', 'BETWEEN', 'NOT BETWEEN' ), true ) ) {
                 if ( ! is_array( $meta_value ) ) {
                     $meta_value = preg_split( '/[,\s]+/', $meta_value );
@@ -812 +812 @@
             $clause_compare  = strtoupper( $clause['compare'] );
             $sibling_compare = strtoupper( $sibling['compare'] );
-            if ( in_array( $clause_compare, $compatible_compares ) && in_array( $sibling_compare, $compatible_compares ) ) {
+            if ( in_array( $clause_compare, $compatible_compares, true ) && in_array( $sibling_compare, $compatible_compares, true ) ) {
                 $alias = $sibling['alias'];
                 break;