Changeset 47550 for trunk/src/wp-includes/class-wp-network-query.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-network-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-network-query.php

@@ -552 +552 @@
             $field  = substr( $orderby, 0, -7 );
             $parsed = "CHAR_LENGTH($wpdb->site.$field)";
-        } elseif ( in_array( $orderby, $allowed_keys ) ) {
+        } elseif ( in_array( $orderby, $allowed_keys, true ) ) {
             $parsed = "$wpdb->site.$orderby";
         }