Changeset 47550 for trunk/src/wp-includes/class-wp-rewrite.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-rewrite.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-rewrite.php

@@ -798 +798 @@
      */
     public function add_rewrite_tag( $tag, $regex, $query ) {
-        $position = array_search( $tag, $this->rewritecode );
+        $position = array_search( $tag, $this->rewritecode, true );
         if ( false !== $position && null !== $position ) {
             $this->rewritereplace[ $position ] = $regex;
@@ -822 +822 @@
      */
     public function remove_rewrite_tag( $tag ) {
-        $position = array_search( $tag, $this->rewritecode );
+        $position = array_search( $tag, $this->rewritecode, true );
         if ( false !== $position && null !== $position ) {
             unset( $this->rewritecode[ $position ] );