Changeset 47550 for trunk/src/wp-includes/class-wp-theme.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-theme.php (modified) (5 diffs)

trunk/src/wp-includes/class-wp-theme.php

@@ -207 +207 @@
 
         // Correct a situation where the theme is 'some-directory/some-theme' but 'some-directory' was passed in as part of the theme root instead.
-        if ( ! in_array( $theme_root, (array) $wp_theme_directories ) && in_array( dirname( $theme_root ), (array) $wp_theme_directories ) ) {
+        if ( ! in_array( $theme_root, (array) $wp_theme_directories, true )
+            && in_array( dirname( $theme_root ), (array) $wp_theme_directories, true )
+        ) {
             $this->stylesheet = basename( $this->theme_root ) . '/' . $this->stylesheet;
             $this->theme_root = dirname( $theme_root );
@@ -476 +478 @@
         );
 
-        return in_array( $offset, $properties );
+        return in_array( $offset, $properties, true );
     }
 
@@ -575 +577 @@
         );
 
-        return in_array( $offset, $keys );
+        return in_array( $offset, $keys, true );
     }
 
@@ -662 +664 @@
      */
     public function exists() {
-        return ! ( $this->errors() && in_array( 'theme_not_found', $this->errors()->get_error_codes() ) );
+        return ! ( $this->errors() && in_array( 'theme_not_found', $this->errors()->get_error_codes(), true ) );
     }
 
@@ -1030 +1032 @@
      */
     public function get_stylesheet_directory() {
-        if ( $this->errors() && in_array( 'theme_root_missing', $this->errors()->get_error_codes() ) ) {
+        if ( $this->errors() && in_array( 'theme_root_missing', $this->errors()->get_error_codes(), true ) ) {
             return '';
         }