Changeset 47550 for trunk/src/wp-includes/class-wp-user-query.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp-user-query.php (modified) (5 diffs)

trunk/src/wp-includes/class-wp-user-query.php

@@ -757 +757 @@
 
         $_orderby = '';
-        if ( in_array( $orderby, array( 'login', 'nicename', 'email', 'url', 'registered' ) ) ) {
+        if ( in_array( $orderby, array( 'login', 'nicename', 'email', 'url', 'registered' ), true ) ) {
             $_orderby = 'user_' . $orderby;
-        } elseif ( in_array( $orderby, array( 'user_login', 'user_nicename', 'user_email', 'user_url', 'user_registered' ) ) ) {
+        } elseif ( in_array( $orderby, array( 'user_login', 'user_nicename', 'user_email', 'user_url', 'user_registered' ), true ) ) {
             $_orderby = $orderby;
         } elseif ( 'name' == $orderby || 'display_name' == $orderby ) {
@@ -829 +829 @@
      */
     public function __get( $name ) {
-        if ( in_array( $name, $this->compat_fields ) ) {
+        if ( in_array( $name, $this->compat_fields, true ) ) {
             return $this->$name;
         }
@@ -844 +844 @@
      */
     public function __set( $name, $value ) {
-        if ( in_array( $name, $this->compat_fields ) ) {
+        if ( in_array( $name, $this->compat_fields, true ) ) {
             return $this->$name = $value;
         }
@@ -858 +858 @@
      */
     public function __isset( $name ) {
-        if ( in_array( $name, $this->compat_fields ) ) {
+        if ( in_array( $name, $this->compat_fields, true ) ) {
             return isset( $this->$name );
         }
@@ -871 +871 @@
      */
     public function __unset( $name ) {
-        if ( in_array( $name, $this->compat_fields ) ) {
+        if ( in_array( $name, $this->compat_fields, true ) ) {
             unset( $this->$name );
         }