Changeset 47550 for trunk/src/wp-includes/class-wp.php

Timestamp:

04/05/2020 03:00:44 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/class-wp.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp.php

@@ -91 +91 @@
      */
     public function add_query_var( $qv ) {
-        if ( ! in_array( $qv, $this->public_query_vars ) ) {
+        if ( ! in_array( $qv, $this->public_query_vars, true ) ) {
             $this->public_query_vars[] = $qv;
         }
@@ -349 +349 @@
             $queryable_post_types = get_post_types( array( 'publicly_queryable' => true ) );
             if ( ! is_array( $this->query_vars['post_type'] ) ) {
-                if ( ! in_array( $this->query_vars['post_type'], $queryable_post_types ) ) {
+                if ( ! in_array( $this->query_vars['post_type'], $queryable_post_types, true ) ) {
                     unset( $this->query_vars['post_type'] );
                 }
@@ -413 +413 @@
                 }
                 $headers['Content-Type'] = get_option( 'html_type' ) . '; charset=' . get_option( 'blog_charset' );
-            } elseif ( in_array( $status, array( 403, 500, 502, 503 ) ) ) {
+            } elseif ( in_array( $status, array( 403, 500, 502, 503 ), true ) ) {
                 $exit_required = true;
             }