Changeset 47550 for trunk/src/wp-includes/comment.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/comment.php (modified) (5 diffs)

trunk/src/wp-includes/comment.php

@@ -1386 +1386 @@
     }
 
-    if ( ! $force_delete && EMPTY_TRASH_DAYS && ! in_array( wp_get_comment_status( $comment ), array( 'trash', 'spam' ) ) ) {
+    if ( ! $force_delete && EMPTY_TRASH_DAYS && ! in_array( wp_get_comment_status( $comment ), array( 'trash', 'spam' ), true ) ) {
         return wp_trash_comment( $comment_id );
     }
@@ -2753 +2753 @@
         foreach ( (array) $to_ping as $tb_ping ) {
             $tb_ping = trim( $tb_ping );
-            if ( ! in_array( $tb_ping, $pinged ) ) {
+            if ( ! in_array( $tb_ping, $pinged, true ) ) {
                 trackback( $tb_ping, $post_title, $excerpt, $post->ID );
                 $pinged[] = $tb_ping;
@@ -2837 +2837 @@
     foreach ( (array) $post_links_temp as $link_test ) {
         // If we haven't pung it already and it isn't a link to itself.
-        if ( ! in_array( $link_test, $pung ) && ( url_to_postid( $link_test ) != $post->ID )
+        if ( ! in_array( $link_test, $pung, true ) && ( url_to_postid( $link_test ) != $post->ID )
                 // Also, let's never ping local attachments.
                 && ! is_local_attachment( $link_test ) ) {
@@ -3118 +3118 @@
      */
     $post_types = apply_filters( 'close_comments_for_post_types', array( 'post' ) );
-    if ( ! in_array( $posts[0]->post_type, $post_types ) ) {
+    if ( ! in_array( $posts[0]->post_type, $post_types, true ) ) {
         return $posts;
     }
@@ -3163 +3163 @@
     /** This filter is documented in wp-includes/comment.php */
     $post_types = apply_filters( 'close_comments_for_post_types', array( 'post' ) );
-    if ( ! in_array( $post->post_type, $post_types ) ) {
+    if ( ! in_array( $post->post_type, $post_types, true ) ) {
         return $open;
     }