Changeset 47550 for trunk/src/wp-includes/compat.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/compat.php (modified) (2 diffs)

trunk/src/wp-includes/compat.php

@@ -90 +90 @@
      * charset just use built-in substr().
      */
-    if ( ! in_array( $encoding, array( 'utf8', 'utf-8', 'UTF8', 'UTF-8' ) ) ) {
+    if ( ! in_array( $encoding, array( 'utf8', 'utf-8', 'UTF8', 'UTF-8' ), true ) ) {
         return is_null( $length ) ? substr( $str, $start ) : substr( $str, $start, $length );
     }
@@ -174 +174 @@
      * just use built-in strlen().
      */
-    if ( ! in_array( $encoding, array( 'utf8', 'utf-8', 'UTF8', 'UTF-8' ) ) ) {
+    if ( ! in_array( $encoding, array( 'utf8', 'utf-8', 'UTF8', 'UTF-8' ), true ) ) {
         return strlen( $str );
     }