Changeset 47550 for trunk/src/wp-includes/customize/class-wp-customize-media-control.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/customize/class-wp-customize-media-control.php (modified) (1 diff)

trunk/src/wp-includes/customize/class-wp-customize-media-control.php

@@ -91 +91 @@
                 // Fake an attachment model - needs all fields used by template.
                 // Note that the default value must be a URL, NOT an attachment ID.
-                $type               = in_array( substr( $this->setting->default, -3 ), array( 'jpg', 'png', 'gif', 'bmp' ) ) ? 'image' : 'document';
+                $ext  = substr( $this->setting->default, -3 );
+                $type = in_array( $ext, array( 'jpg', 'png', 'gif', 'bmp' ), true ) ? 'image' : 'document';
+
                 $default_attachment = array(
                     'id'    => 1,