Changeset 47550 for trunk/src/wp-includes/kses.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/kses.php (modified) (5 diffs)

trunk/src/wp-includes/kses.php

@@ -794 +794 @@
 
         // Sanitize URI values.
-        if ( in_array( strtolower( $name ), $uris ) ) {
+        if ( in_array( strtolower( $name ), $uris, true ) ) {
             $value = wp_kses_bad_protocol( $value, $allowed_protocols );
         }
@@ -1286 +1286 @@
                     // "value"
                     $thisval = $match[1];
-                    if ( in_array( strtolower( $attrname ), $uris ) ) {
+                    if ( in_array( strtolower( $attrname ), $uris, true ) ) {
                         $thisval = wp_kses_bad_protocol( $thisval, $allowed_protocols );
                     }
@@ -1307 +1307 @@
                     // 'value'
                     $thisval = $match[1];
-                    if ( in_array( strtolower( $attrname ), $uris ) ) {
+                    if ( in_array( strtolower( $attrname ), $uris, true ) ) {
                         $thisval = wp_kses_bad_protocol( $thisval, $allowed_protocols );
                     }
@@ -1328 +1328 @@
                     // value
                     $thisval = $match[1];
-                    if ( in_array( strtolower( $attrname ), $uris ) ) {
+                    if ( in_array( strtolower( $attrname ), $uris, true ) ) {
                         $thisval = wp_kses_bad_protocol( $thisval, $allowed_protocols );
                     }
@@ -1783 +1783 @@
 
     $i = $matches[1];
-    return ( ! in_array( $i, $allowedentitynames ) ) ? "&$i;" : "&$i;";
+    return ( ! in_array( $i, $allowedentitynames, true ) ) ? "&$i;" : "&$i;";
 }