Changeset 47550 for trunk/src/wp-includes/link-template.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/link-template.php (modified) (7 diffs)

trunk/src/wp-includes/link-template.php

@@ -147 +147 @@
     } elseif ( 'attachment' === $post->post_type ) {
         return get_attachment_link( $post, $leavename );
-    } elseif ( in_array( $post->post_type, get_post_types( array( '_builtin' => false ) ) ) ) {
+    } elseif ( in_array( $post->post_type, get_post_types( array( '_builtin' => false ) ), true ) ) {
         return get_post_permalink( $post, $leavename, $sample );
     }
@@ -166 +166 @@
     $permalink = apply_filters( 'pre_post_link', $permalink, $post, $leavename );
 
-    if ( '' != $permalink && ! in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft', 'future' ) ) ) {
+    if ( '' != $permalink && ! in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft', 'future' ), true ) ) {
 
         $category = '';
@@ -276 +276 @@
     $slug = $post->post_name;
 
-    $draft_or_pending = get_post_status( $post ) && in_array( get_post_status( $post ), array( 'draft', 'pending', 'auto-draft', 'future' ) );
+    $draft_or_pending = get_post_status( $post ) && in_array( get_post_status( $post ), array( 'draft', 'pending', 'auto-draft', 'future' ), true );
 
     $post_type = get_post_type_object( $post->post_type );
@@ -372 +372 @@
     $post = get_post( $post );
 
-    $draft_or_pending = in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft' ) );
+    $draft_or_pending = in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft' ), true );
 
     $link = $wp_rewrite->get_page_permastruct();
@@ -418 +418 @@
     $post   = get_post( $post );
     $parent = ( $post->post_parent > 0 && $post->post_parent != $post->ID ) ? get_post( $post->post_parent ) : false;
-    if ( $parent && ! in_array( $parent->post_type, get_post_types() ) ) {
+    if ( $parent && ! in_array( $parent->post_type, get_post_types(), true ) ) {
         $parent = false;
     }
@@ -3183 +3183 @@
     }
 
-    if ( ! in_array( $scheme, array( 'http', 'https', 'relative' ) ) ) {
+    if ( ! in_array( $scheme, array( 'http', 'https', 'relative' ), true ) ) {
         if ( is_ssl() && ! is_admin() && 'wp-login.php' !== $pagenow ) {
             $scheme = 'https';
@@ -3498 +3498 @@
     $orig_scheme     = $scheme;
 
-    if ( ! in_array( $scheme, array( 'http', 'https', 'relative' ) ) ) {
+    if ( ! in_array( $scheme, array( 'http', 'https', 'relative' ), true ) ) {
         $scheme = is_ssl() && ! is_admin() ? 'https' : 'http';
     }