Changeset 47550 for trunk/src/wp-includes/load.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/load.php (modified) (3 diffs)

trunk/src/wp-includes/load.php

@@ -15 +15 @@
 function wp_get_server_protocol() {
     $protocol = isset( $_SERVER['SERVER_PROTOCOL'] ) ? $_SERVER['SERVER_PROTOCOL'] : '';
-    if ( ! in_array( $protocol, array( 'HTTP/1.1', 'HTTP/2', 'HTTP/2.0' ) ) ) {
+    if ( ! in_array( $protocol, array( 'HTTP/1.1', 'HTTP/2', 'HTTP/2.0' ), true ) ) {
         $protocol = 'HTTP/1.0';
     }
@@ -41 +41 @@
     $input = array_merge( $_GET, $_POST, $_COOKIE, $_SERVER, $_ENV, $_FILES, isset( $_SESSION ) && is_array( $_SESSION ) ? $_SESSION : array() );
     foreach ( $input as $k => $v ) {
-        if ( ! in_array( $k, $no_unset ) && isset( $GLOBALS[ $k ] ) ) {
+        if ( ! in_array( $k, $no_unset, true ) && isset( $GLOBALS[ $k ] ) ) {
             unset( $GLOBALS[ $k ] );
         }
@@ -684 +684 @@
             && file_exists( WP_PLUGIN_DIR . '/' . $plugin ) // $plugin must exist.
             // Not already included as a network plugin.
-            && ( ! $network_plugins || ! in_array( WP_PLUGIN_DIR . '/' . $plugin, $network_plugins ) )
+            && ( ! $network_plugins || ! in_array( WP_PLUGIN_DIR . '/' . $plugin, $network_plugins, true ) )
             ) {
             $plugins[] = WP_PLUGIN_DIR . '/' . $plugin;