Changeset 47550 for trunk/src/wp-includes/option.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/option.php (modified) (3 diffs)

trunk/src/wp-includes/option.php

@@ -133 +133 @@
     }
 
-    if ( in_array( $option, array( 'siteurl', 'home', 'category_base', 'tag_base' ) ) ) {
+    if ( in_array( $option, array( 'siteurl', 'home', 'category_base', 'tag_base' ), true ) ) {
         $value = untrailingslashit( $value );
     }
@@ -1773 +1773 @@
         $no_timeout       = array( 'update_core', 'update_plugins', 'update_themes' );
         $transient_option = '_site_transient_' . $transient;
-        if ( ! in_array( $transient, $no_timeout ) ) {
+        if ( ! in_array( $transient, $no_timeout, true ) ) {
             $transient_timeout = '_site_transient_timeout_' . $transient;
             $timeout           = get_site_option( $transient_timeout );
@@ -2233 +2233 @@
     }
 
-    $pos = array_search( $option_name, (array) $new_whitelist_options[ $option_group ] );
+    $pos = array_search( $option_name, (array) $new_whitelist_options[ $option_group ], true );
     if ( false !== $pos ) {
         unset( $new_whitelist_options[ $option_group ][ $pos ] );