Changeset 47550 for trunk/src/wp-includes/post-template.php

Timestamp:

04/05/2020 03:00:44 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/post-template.php (modified) (4 diffs)

trunk/src/wp-includes/post-template.php

@@ -1033 +1033 @@
         $url = get_permalink();
     } else {
-        if ( '' == get_option( 'permalink_structure' ) || in_array( $post->post_status, array( 'draft', 'pending' ) ) ) {
+        if ( '' == get_option( 'permalink_structure' ) || in_array( $post->post_status, array( 'draft', 'pending' ), true ) ) {
             $url = add_query_arg( 'page', $i, get_permalink() );
         } elseif ( 'page' == get_option( 'show_on_front' ) && get_option( 'page_on_front' ) == $post->ID ) {
@@ -1396 +1396 @@
     $args     = wp_parse_args( $args, $defaults );
 
-    if ( ! in_array( $args['item_spacing'], array( 'preserve', 'discard' ) ) ) {
+    if ( ! in_array( $args['item_spacing'], array( 'preserve', 'discard' ), true ) ) {
         // Invalid value, fall back to default.
         $args['item_spacing'] = $defaults['item_spacing'];
@@ -1812 +1812 @@
     }
 
-    if ( ! in_array( $revision->post_type, array( 'post', 'page', 'revision' ) ) ) {
+    if ( ! in_array( $revision->post_type, array( 'post', 'page', 'revision' ), true ) ) {
         return false;
     }
@@ -1853 +1853 @@
     }
 
-    if ( ! in_array( $revision->post_type, array( 'post', 'page', 'revision' ) ) ) {
+    if ( ! in_array( $revision->post_type, array( 'post', 'page', 'revision' ), true ) ) {
         return false;
     }