Changeset 47550 for trunk/src/wp-includes/rewrite.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-includes/rewrite.php (modified) (3 diffs)

trunk/src/wp-includes/rewrite.php

@@ -248 +248 @@
     global $wp_rewrite;
 
-    if ( ! in_array( $feedname, $wp_rewrite->feeds ) ) {
+    if ( ! in_array( $feedname, $wp_rewrite->feeds, true ) ) {
         $wp_rewrite->feeds[] = $feedname;
     }
@@ -365 +365 @@
     // Identify the 'postname' position in the permastruct array.
     $permastructs   = array_values( array_filter( explode( '/', get_option( 'permalink_structure' ) ) ) );
-    $postname_index = array_search( '%postname%', $permastructs );
+    $postname_index = array_search( '%postname%', $permastructs, true );
 
     if ( false === $postname_index ) {
@@ -597 +597 @@
             $query = array();
             foreach ( (array) $query_vars as $key => $value ) {
-                if ( in_array( $key, $wp->public_query_vars ) ) {
+                if ( in_array( $key, $wp->public_query_vars, true ) ) {
                     $query[ $key ] = $value;
                     if ( isset( $post_type_query_vars[ $key ] ) ) {