Changeset 47550 for trunk/src/wp-signup.php

Timestamp:

04/05/2020 03:00:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.

This reduces the number of WordPress.PHP.StrictInArray.MissingTrueStrict issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

File:

• trunk/src/wp-signup.php (modified) (4 diffs)

trunk/src/wp-signup.php

@@ -10 +10 @@
 nocache_headers();
 
-if ( is_array( get_site_option( 'illegal_names' ) ) && isset( $_GET['new'] ) && in_array( $_GET['new'], get_site_option( 'illegal_names' ) ) ) {
+if ( is_array( get_site_option( 'illegal_names' ) ) && isset( $_GET['new'] ) && in_array( $_GET['new'], get_site_option( 'illegal_names' ), true ) ) {
     wp_redirect( network_home_url() );
     die();
@@ -170 +170 @@
 
             // Use US English if the default isn't available.
-            if ( ! in_array( $lang, $languages ) ) {
+            if ( ! in_array( $lang, $languages, true ) ) {
                 $lang = '';
             }
@@ -439 +439 @@
         $languages = signup_get_available_languages();
 
-        if ( in_array( $_POST['WPLANG'], $languages ) ) {
+        if ( in_array( $_POST['WPLANG'], $languages, true ) ) {
             $language = wp_unslash( sanitize_text_field( $_POST['WPLANG'] ) );
 
@@ -790 +790 @@
         $languages = signup_get_available_languages();
 
-        if ( in_array( $_POST['WPLANG'], $languages ) ) {
+        if ( in_array( $_POST['WPLANG'], $languages, true ) ) {
             $language = wp_unslash( sanitize_text_field( $_POST['WPLANG'] ) );