Changeset 47557 for trunk/src/wp-admin/includes/class-walker-category-checklist.php

Timestamp:

04/09/2020 03:41:04 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search().

This addresses all the remaining WordPress.PHP.StrictInArray.MissingTrueStrict issues in core.

Includes minor code layout fixes for better readability.

Follow-up to [47550].

See #49542.

File:

• trunk/src/wp-admin/includes/class-walker-category-checklist.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-walker-category-checklist.php

@@ -84 +84 @@
         $args['popular_cats'] = empty( $args['popular_cats'] ) ? array() : $args['popular_cats'];
 
-        $class = in_array( $category->term_id, $args['popular_cats'] ) ? ' class="popular-category"' : '';
+        $class = in_array( $category->term_id, $args['popular_cats'], true ) ? ' class="popular-category"' : '';
 
         $args['selected_cats'] = empty( $args['selected_cats'] ) ? array() : $args['selected_cats'];
@@ -92 +92 @@
             $inner_class  = 'category';
 
-            if ( in_array( $category->term_id, $args['selected_cats'] ) ) {
+            if ( in_array( $category->term_id, $args['selected_cats'], true ) ) {
                 $inner_class .= ' selected';
                 $aria_checked = 'true';
@@ -103 +103 @@
                 esc_html( apply_filters( 'the_category', $category->name, '', '' ) ) . '</div>';
         } else {
+            $is_selected = in_array( $category->term_id, $args['selected_cats'], true );
+            $is_disabled = ! empty( $args['disabled'] );
+
             $output .= "\n<li id='{$taxonomy}-{$category->term_id}'$class>" .
                 '<label class="selectit"><input value="' . $category->term_id . '" type="checkbox" name="' . $name . '[]" id="in-' . $taxonomy . '-' . $category->term_id . '"' .
-                checked( in_array( $category->term_id, $args['selected_cats'] ), true, false ) .
-                disabled( empty( $args['disabled'] ), false, false ) . ' /> ' .
+                checked( $is_selected, true, false ) .
+                disabled( $is_disabled, true, false ) . ' /> ' .
                 /** This filter is documented in wp-includes/category-template.php */
                 esc_html( apply_filters( 'the_category', $category->name, '', '' ) ) . '</label>';