Changeset 47557 for trunk/src/wp-admin/includes/ms.php

Timestamp:

04/09/2020 03:41:04 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search().

This addresses all the remaining WordPress.PHP.StrictInArray.MissingTrueStrict issues in core.

Includes minor code layout fixes for better readability.

Follow-up to [47550].

See #49542.

File:

• trunk/src/wp-admin/includes/ms.php (modified) (2 diffs)

trunk/src/wp-admin/includes/ms.php

@@ -923 +923 @@
                         )
                     );
+
                     if ( is_array( $blog_users ) && ! empty( $blog_users ) ) {
                         $user_site      = "<a href='" . esc_url( get_home_url( $details->userblog_id ) ) . "'>{$details->blogname}</a>";
@@ -928 +929 @@
                         $user_dropdown .= "<select name='blog[$user_id][$key]' id='reassign_user'>";
                         $user_list      = '';
+
                         foreach ( $blog_users as $user ) {
-                            if ( ! in_array( $user->ID, $allusers ) ) {
+                            if ( ! in_array( (int) $user->ID, $allusers, true ) ) {
                                 $user_list .= "<option value='{$user->ID}'>{$user->user_login}</option>";
                             }
                         }
+
                         if ( '' == $user_list ) {
                             $user_list = $admin_out;
                         }
+
                         $user_dropdown .= $user_list;
                         $user_dropdown .= "</select>\n";