Changeset 47557 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

04/09/2020 03:41:04 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict type check for in_array() and array_search().

This addresses all the remaining WordPress.PHP.StrictInArray.MissingTrueStrict issues in core.

Includes minor code layout fixes for better readability.

Follow-up to [47550].

See #49542.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3138 +3138 @@
             // Loop over posts and relocate stickies to the front.
             for ( $i = 0; $i < $num_posts; $i++ ) {
-                if ( in_array( $this->posts[ $i ]->ID, $sticky_posts ) ) {
+                if ( in_array( $this->posts[ $i ]->ID, $sticky_posts, true ) ) {
                     $sticky_post = $this->posts[ $i ];
                     // Remove sticky from current position.
@@ -3147 +3147 @@
                     $sticky_offset++;
                     // Remove post from sticky posts array.
-                    $offset = array_search( $sticky_post->ID, $sticky_posts );
+                    $offset = array_search( $sticky_post->ID, $sticky_posts, true );
                     unset( $sticky_posts[ $offset ] );
                 }